If everyone followed that advice, nobody would ever express their opinion and nobody would ever say anything negative.
Being able to critique things is really important. It's essential for identifying problems, developing good ideas, and improving systems and products and well as people's personal development.
You say to explain how things could be improved rather than talk about the problems with them. The problem with that approach is it's usually important to first identify exactly what the problem is, before coming up with ideas for how to fix it. Sometimes it's not obvious how to improve things. It may take days or weeks to get to that point.
Pixar use a technique called "plussing"[1] where any critique given is framed as a positive constructive addition. Eg you accept something for what it is and suggest a way to improve it rather than saying it's bad or wrong. I've tried to use it, and continue to try, but it's hard work. When I manage to do it properly it works very well.
I addressed this kind of thing in my original comment: it is often important to first clearly identify the problems before trying to come up with solutions, and you may have to go days or weeks without being able to develop possible solutions.
That doesn't matter though. The point of plussing is about how you word your criticism so people don't feel the need to be defensive or antagonistic.
If there's a problem that can't be solved for a while there's world of difference between saying "Your code is wrong. This is a problem we can't solve for weeks." and "You've made a great start and this code is going to be really useful as a foundation to build on, but there's a new challenge we didn't foresee so we'll need to make a couple of changes when we have more data."
I've never met a technical problem that couldn't be solved better with good people skills. Knowing how to get good work from people is key for any tech business.
Then your hiring process, the team lead's leadership skills, and whole team's requirements gathering and code review processes all need some attention.
There is nothing that you can't express in a kind and constructive manner. Speak objectively, keeping judgments, blame and "you" statements out of it.
"It's been difficult to add new features to the code base because it's grown so much and I think we need to consider a serious refactoring project. The best approach in my opinion is to take the lessons of the past and start over for X and Y reasons."
Will everyone agree with you? Maybe not. Will it work? Maybe it won't. But that's also true if you say "your code sucks," and you won't have to be bogged down in savage internecine code warfare.
It sounds like you're agreeing with me that criticism is important. I never advocated for poorly communicating that criticism, even though that seems to be what you're implying.
To repeat the point of the comment you replied to, it can be much more effective to first work on identifying exactly what the problem is, and if you always expect you can immediately identify solutions it'll hamper your ability to address tough problems.
Without commenting on whether I agree with their advice or not, I just want to point out that "if everyone x then y" is a poor argument against x.
Plenty of the things we do that are good for us would turn out poorly for us if everyone did them. Plenty of the things we do that are good for the groups we belong to would turn out poorly if everyone in the group did them.
Being able to critique things is really important. It's essential for identifying problems, developing good ideas, and improving systems and products and well as people's personal development.
You say to explain how things could be improved rather than talk about the problems with them. The problem with that approach is it's usually important to first identify exactly what the problem is, before coming up with ideas for how to fix it. Sometimes it's not obvious how to improve things. It may take days or weeks to get to that point.